#186: Exporter's filename validations #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/terrain_3d_storage.cpp
Outdated
| // Simple file name validation | ||
| static String bad_chars = "!@%^*~|\""; | ||
| for (int i = 0; i < bad_chars.length(); ++i) | ||
| { |
There was a problem hiding this comment.
I'm going to make changes so I can get this merged in. In the future, please format with braces on the same line and opt for snake case, except in class names. See formatting in https://github.com/TokisanGames/Terrain3D/blob/0.9/CONTRIBUTING.md.
Also make sure to install the clang hooks.
|
Ok, looks good. I added some other updates that needed to be made. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 checks for the exporter filename:
Fixes #186