Add terrain_edited signal to Terrain3DEditor #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokisanGames
requested changes
Dec 26, 2023
So that tool scripts and other addon scripts besides the Terrain3D addon can access it. Currently Terrain3DEditor is created and the reference held by the EditorPlugin, but other scripts can't access this. |
|
I've updated my branch to address your other comments. |
|
Thanks! |
| @@ -123,6 +153,10 @@ void Terrain3DEditor::_operate_map(Vector3 p_global_position, real_t p_camera_di | |||
| } | |||
| Object::cast_to<Node>(_terrain->get_plugin()->get("ui"))->call("set_decal_rotation", rot); | |||
|
|
|||
| AABB edited_area; | |||
| edited_area.position = p_global_position - Vector3(brush_size, 0.0, brush_size) / 2; | |||
There was a problem hiding this comment.
Shouldn't 2 be float just to avoid unnecessary conversions? I'm changing this in the new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #270.
Terrain3DEditor becomes a singleton, and gains a new
terrain_edited(edited_area: AABB)signal. The use case is integration with other level design tools and scripts - see the linked issue.The signal is emitted whenever:
In the end I decided not to include the map_type parameter in the signal, as it seems like this would not be relevant to non-brush-related tools (region add/remove, etc.).