API change first pass - Breaks loading region_offsets! #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokisanGames
force-pushed
the
region-offsets-locations
branch
from
47cb241
to
4fcb2a4
Compare
11 tasks
|
Updated Op with signal changes |
TokisanGames
force-pushed
the
region-offsets-locations
branch
2 times, most recently
from
e89a0a3
to
8d93422
Compare
TokisanGames
force-pushed
the
region-offsets-locations
branch
from
9156142
to
299be2d
Compare
TokisanGames
force-pushed
the
region-offsets-locations
branch
from
299be2d
to
f4038b1
Compare
TokisanGames
force-pushed
the
region-offsets-locations
branch
from
f4038b1
to
7fa8f59
Compare
TokisanGames
force-pushed
the
region-offsets-locations
branch
5 times, most recently
from
722b511
to
502dc0b
Compare
TokisanGames
force-pushed
the
region-offsets-locations
branch
from
502dc0b
to
3dd962d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes to existing functions (from main):
Breaking change: This PR currently breaks user scenes as region_offsets aren't converted to region_locations. It is a precursor to #374 which will have upgrade code.
Functions
set/get_region_offsetsset/get_region_locationsget_region_offsetget_region_locationget_region_offset_from_indexget_region_location_from_idget_region_indexget_region_idget_region_index_from_offsetget_region_id_from_locationclear_by_offsetclear_by_locationSignals
storage_changedregions_changedmaps_changedregion_map_changedheight_maps_changedheight_maps_changedcontrol_maps_changedcolor_maps_changedmaps_edited(AABB)maps_edited(AABB)