Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to insert input for edit cell in custom place of DOM #140

Closed
Imperat opened this issue Jul 16, 2018 · 6 comments
Closed

Add ability to insert input for edit cell in custom place of DOM #140

Imperat opened this issue Jul 16, 2018 · 6 comments

Comments

@Imperat
Copy link
Contributor

Imperat commented Jul 16, 2018

I use canvas data grid with fullscreen api. When my div element (parent of canvas data grid) is going into fullscreen mode the input control is going to uneditable.
Can we add api to insert input component in custom place of dom?

fiddle to reproduce bug with fullscreen mode:
http://jsfiddle.net/sg96jL3k/

@TonyGermaneri
Copy link
Owner

Thanks for the help!!

I don't think this will break any previous implementations, but I could be wrong.

@Imperat
Copy link
Contributor Author

Imperat commented Jul 23, 2018

Hi, @TonyGermaneri. Please, have a note that fullscreen mode also affects context menu. I'm going to fix it again in weekends

@TonyGermaneri TonyGermaneri reopened this Jul 23, 2018
@TonyGermaneri
Copy link
Owner

Ah, yeah, it would.

TonyGermaneri added a commit that referenced this issue Sep 6, 2018
…th document.body -> document change and better style detection.
@TonyGermaneri
Copy link
Owner

Hi @Imperat I've added the event appendeditinput to accommodate your use case. Attach to the event and run e.preventDefault(); to stop it from adding the input to the body. You can then add the input where you like and alter it if need be.

@Imperat
Copy link
Contributor Author

Imperat commented Sep 9, 2018

Thanks a lot, @TonyGermaneri. Now I use another event preventing for resolve this case. I forget it in today Sunday.. probably beforebeginedit :)
Tool which I implement using your library is actively used in production! Thank you again for you great library!

@TonyGermaneri
Copy link
Owner

Tool which I implement using your library is actively used in production!

That makes my day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants