Dynamic Nation Colours #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can try this out in a few days as we will be testing some other towny related things then anyway. |
|
Actually, does this work in 1.13.2 as all our servers including test servers are running that? |
|
Hi Karl. The required compatibility branch for that is: Goosius1:dynamic_nation_colours_1.13_compatibility |
added 2 commits
February 12, 2020 09:49
- With this feature, a nation can choose IN-GAME what their dynmap colours will be - This is done by placing one or both of the following tags on the nation board: map_border_style=45345,435.0,45235 # this sets....colour, opacity, weight map_fill_style=234234,3242.0 # this sets....colour, opacity TESTING - It would be great if somebody interested in this feature could test it. - I don't currently have the experience with dynmap to quickly set it up locally
Goosius1
force-pushed
the
dynamic_nation_colours
branch
2 times, most recently
from
5a3f904
to
f74d73f
Compare
Goosius1
changed the title
Goosius1
force-pushed
the
dynamic_nation_colours
branch
from
f74d73f
to
97154d2
Compare
Goosius1
changed the title
- Updated the towny jar to the 1.13 compatibility one - Updated some other versioning in pom file (to suit 1.13 compatibility) - Also fixed a pre-existing compile type error for 'lossy conversion' - Updated pom - set towny to latest version
Goosius1
force-pushed
the
dynamic_nation_colours
branch
from
0d443d5
to
40fb4b9
Compare
- Added code to deal with users putting in upper/lowercase for the keyword
- plugin.yml: Update api-version to 1.14
- README Update:
- Redone 'Supported Versions' and 'Building from Source'
- POM Update:
- "Fixed" POM model from using tabs to using 4 spaces (IDE automated,
I'm too lazy to revert this...
- Fixed GitHub Packages repository, github-Towny
- Updated Dependencies
- Towny to 0.95.2.10
- TownyChat to 0.65
- Bukkit API to 1.14.4-R0.1-SNAPSHOT
- DynmapAPI to 2.5 (from 2.2) (Should technically be 3.0-SNAPSHOT,
but the maven for it is out of date)
- Added Repository to dynamically grab the Bukkit API instead of
manually downloading.
- Fix for [home] showing beside town names.
- Fix for /dynmap reload breaking dynmap-towny.
|
it'll be more player-friendly if commands were used (like /nationcolor + hex) to change appearance on dynmap, insted of nation board. |
|
Yes, I totally agree
|
Goosius1
force-pushed
the
dynamic_nation_colours
branch
from
91d7c1a
to
6461dbe
Compare
* Added a dynmap config for this feature - on/off
* If feature is on, nation colors are read from the nation object as indicated
If feature is off, nation colors are read using the existing pattern
* Also updated pom for continued usability
- set townychat 68 to be in pom
because that is the version which is currently offered in the github
package along with the latest towny release 0.96.1.0.
- set towny jar to be system in pom like the other deps,
because otherwise towny jar updates were not getting picked up.
Goosius1
force-pushed
the
dynamic_nation_colours
branch
from
6461dbe
to
1463d7b
Compare
LlmDl
requested changes
Apr 16, 2020
- updated towny version to the earliest one which supports the colours feature
Goosius1
commented
Apr 24, 2020
LlmDl
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tha towny code can be reviewed in the "Dynamic nation colours" PR in the Towny repo.
DESCRIPTION