-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Nation Colours #4
Conversation
I can try this out in a few days as we will be testing some other towny related things then anyway. |
Actually, does this work in 1.13.2 as all our servers including test servers are running that? |
Hi Karl. The required compatibility branch for that is: Goosius1:dynamic_nation_colours_1.13_compatibility |
- With this feature, a nation can choose IN-GAME what their dynmap colours will be - This is done by placing one or both of the following tags on the nation board: map_border_style=45345,435.0,45235 # this sets....colour, opacity, weight map_fill_style=234234,3242.0 # this sets....colour, opacity TESTING - It would be great if somebody interested in this feature could test it. - I don't currently have the experience with dynmap to quickly set it up locally
5a3f904
to
f74d73f
Compare
f74d73f
to
97154d2
Compare
- Updated the towny jar to the 1.13 compatibility one - Updated some other versioning in pom file (to suit 1.13 compatibility) - Also fixed a pre-existing compile type error for 'lossy conversion' - Updated pom - set towny to latest version
0d443d5
to
40fb4b9
Compare
- Added code to deal with users putting in upper/lowercase for the keyword
- plugin.yml: Update api-version to 1.14 - README Update: - Redone 'Supported Versions' and 'Building from Source' - POM Update: - "Fixed" POM model from using tabs to using 4 spaces (IDE automated, I'm too lazy to revert this... - Fixed GitHub Packages repository, github-Towny - Updated Dependencies - Towny to 0.95.2.10 - TownyChat to 0.65 - Bukkit API to 1.14.4-R0.1-SNAPSHOT - DynmapAPI to 2.5 (from 2.2) (Should technically be 3.0-SNAPSHOT, but the maven for it is out of date) - Added Repository to dynamically grab the Bukkit API instead of manually downloading. - Fix for [home] showing beside town names. - Fix for /dynmap reload breaking dynmap-towny.
it'll be more player-friendly if commands were used (like /nationcolor + hex) to change appearance on dynmap, insted of nation board. |
Yes, I totally agree
|
91d7c1a
to
6461dbe
Compare
* Added a dynmap config for this feature - on/off * If feature is on, nation colors are read from the nation object as indicated If feature is off, nation colors are read using the existing pattern * Also updated pom for continued usability - set townychat 68 to be in pom because that is the version which is currently offered in the github package along with the latest towny release 0.96.1.0. - set towny jar to be system in pom like the other deps, because otherwise towny jar updates were not getting picked up.
6461dbe
to
1463d7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
- updated towny version to the earliest one which supports the colours feature
SUMMARY
Tha towny code can be reviewed in the "Dynamic nation colours" PR in the Towny repo.
DESCRIPTION