Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JUCE to develop (post 7.0.5) for VST host fix #104

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

sudara
Copy link
Contributor

@sudara sudara commented Feb 16, 2023

No description provided.

@drowaudio drowaudio merged commit 8756d84 into Tracktion:develop Feb 16, 2023
@drowaudio
Copy link
Contributor

This is failing the CI for me now when testing the juce example VST3 plugins.
I’m guessing that’s because they’re now VST3 bundles? Did it pass on your CI?

@sudara
Copy link
Contributor Author

sudara commented Feb 17, 2023

Sorry, I opened the PR before tests wrapped on my fork. Didn’t expect the merge, was going to add something to changlists and bump version to 1.0.3, I can take a look tomorrow!

@sudara
Copy link
Contributor Author

sudara commented Feb 17, 2023

Looks like all platforms are failing (segfault) right after Starting tests in: pluginval / Listing available buses...

Possibly related: https://forum.juce.com/t/crash-juce-vst3-linux-cant-pass-pluginval/54927?u=sudara

I'm not able to verify locally, because #101 and #102 make pluginval consume 100% CPU and stall on my current plugin, perhaps due to the fact I have many hundreds of parameters and setState is now being called once per param.

@sudara
Copy link
Contributor Author

sudara commented Feb 17, 2023

Ok, tried another plugin, couldn't reproduce locally. Have to move on for now, but I can look into the JUCE examples next. Feel free to revert if you want develop happy.

@sudara
Copy link
Contributor Author

sudara commented Feb 17, 2023

Seems like it might be choking on listBuses (ut, instance, false) — on all platforms the true version seems to produce its output and then it bails.

@sudara
Copy link
Contributor Author

sudara commented Feb 20, 2023

@drowaudio
Copy link
Contributor

Ok, so it looks like it's a juce bug and we'll just have to wait for it to get fixed there?

@sudara
Copy link
Contributor Author

sudara commented Feb 22, 2023

Seems that way! If a resolution doesn't seem imminent I can look into a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants