Contact team split #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated versioning number to check out bransh pushes. Atom is handling this strangely.
Comments have been added to the main HousingOutcomes.py script as well as some cleanup to make the pre-existing comments easier to read. The spreadsheet will now have a default name and a default extension. The Rundate class, which was previously an inactive element of the HousingOutcomes.py script. This class has been moved into its own .py file so that it can be worked on idependently without making the code overly confusing. I feel like having only a single class per .py file also conforms to best practices.
Placement program identifiers have been added to the report so that end users can filter for follow ups relevant to them. To that end the ART report was modified to include an addition sheet showing placement information. If the placement dates do not match the follow up dates this will cause an issue. An accompanying DQ report will be required to ensure that this all works as intended and that staff are entering data correctly. Additionally, the RunDate.py file has been removed as it seems to serve no purpose. I wonder what I was thinking when I added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a lot of changes here but nothing that seems to break functionality of the original report.
Comments were added throughout to improve readability.
The main script was altered to account for changes made to the raw data which now includes a sheet of placement information. This placement data is read into its own data frame which is then merged into the follow-up data frame using a left merge on the placement date and client unique id columns. The placement date, client unique id, and client uid_y columns are dropped prior to saving the report to excel in the interest of eliminating unneeded information from the final report.
The branch is currently awaiting QA work prior to being merged back into the main branch.