Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addListener('insert/update/delete') events #1174

Closed
wants to merge 2 commits into from
Closed

Conversation

131
Copy link

@131 131 commented Jun 5, 2019

The `addListener('insert /update/delete') API throw

Error: update is not a valid configuration option
    at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
    at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
    at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
    at <anonymous> Error: update is not a valid configuration option
    at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
    at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
    at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
    at <anonymous>

The following adjustement in Database::Configure make it work !

@131
Copy link
Author

131 commented Jun 5, 2019

I can add tests & documentation if requested

@kewde
Copy link
Collaborator

kewde commented Jun 13, 2019

Thank you for your pull request.
Additional tests and documentation are required for small changes to make sure that it works as intended.

@little-brother
Copy link

Any updates?

@daniellockyer
Copy link
Member

Hey @131, this uses NAN but we've since switched to N-API. Would you be able to rework your PR? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants