Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include the string method into the output #46

Merged
merged 2 commits into from
May 22, 2021

Conversation

mgoodfellow
Copy link
Contributor

As discussed in: #45

As far as I can see, there is no reason to remove this method when targeting non-netstandard outputs (net/netcore etc).

@Turnerj
Copy link
Owner

Turnerj commented May 22, 2021

Thanks for the PR! I've added what you suggested in the issue about using AsSpan so that the code uses a single path. I ran some benchmarks to see if there was any performance loss but I can't see any. Slight change to code size but that's not a big deal.

@Turnerj Turnerj merged commit 9d90093 into Turnerj:main May 22, 2021
@Turnerj Turnerj linked an issue May 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage in .NetStandard2.0 library can cause MethodNotFound exception
2 participants