Fx Rewrite #24
Merged
Fx Rewrite #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provision of resources Sharing Fx Subject enhancements RefSubject expansision Begin exposing Fx public API
Unfortunately, TodoMVC example is broken though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another rewrite of the core Fx abstraction. Primarily the goal is to better manage scopes, and the timely interruption when portions of the stream graph are no longer needed. Also Scope is more often exposed in the
Rof your Fx when it is being utilized internally to an operator, to make it clear Scopes are being utilize and they are to be attached to an outer/parent Scope.In addition to the Scope-related changes, performance optimizations have taken place regarding fusion, closure creation, diffing and more. Overall the performance is either exactly the same, but in many common cases 2-10x faster than the current version.
Furthermore a large refactoring of RefSubject has taken place, removing the many methods it had in favor of functions in the RefSubject module itself to allow for better tree-shaking of operators you might not need. The Computed/Filtered modules have also been removed and merged into the RefSubject module, as Computed + Filtered types have no purpose without a source RefSubject. Many of the operators like tuple/struct now accept any of the three types and will return the correct type accordingly.
Sinks have been refactored to remove the need for Sink.Sink<E, A> and Sink.WithContext<R, E, A> to just Sink.Sink<R, E, A>, as well as many new functions.
A Push module has been introduced to represent types which are both an Fx and a Sink, but which might not have the same values for its inputs as its outputs.