You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.d.ts files from node_modules are not triggering recompilation after hot change (Use case: yarn link/yalc link)
After debugging I've found that after changing some file at node_modules/whatever/file.d.ts, webpack detects my change, but fork-ts-checker-webpack-plugin ignores the change.
From my point of view BUILTIN_IGNORED_DIRS should be extracted as parameter, even when the package provide the default values, we should enable user to change in whatever way they want.
Ignoring node_modules creates more issues than it solves. We use webpack watcher anyway, so ignoring these files or not will not affect watcher performance. User can always add node_modules to ignored dirs manually in webpack config.
Closes: #752
Current behavior
.d.ts
files from node_modules are not triggering recompilation after hot change (Use case: yarn link/yalc link)After debugging I've found that after changing some file at
node_modules/whatever/file.d.ts
, webpack detects my change, but fork-ts-checker-webpack-plugin ignores the change.https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/blob/main/src/watch/inclusive-node-watch-file-system.ts#L14
This default configuration is making that this line is printed.
Expected behavior
From my point of view
BUILTIN_IGNORED_DIRS
should be extracted as parameter, even when the package provide the default values, we should enable user to change in whatever way they want.Steps to reproduce the issue
node_modules/fake/package.json
node_modules/fake/a.js
node_modules/fake/a.d.ts
index.ts:
yarn dev
Types should be marked as broken but is not.
Issue reproduction repository
Environment
The text was updated successfully, but these errors were encountered: