Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix useTypescriptIncrementalApi flag to work according to docs #223

Merged

Conversation

yanivefraim
Copy link
Contributor

useTypescriptIncrementalApi doesn't work as supposed to - it is not true by default, for TS version > 3.

fixes #222

@johnnyreilly
Copy link
Member

johnnyreilly commented Mar 3, 2019

First of all, thanks for this - good catch!

There's now some failing tests which I believe are related to #219

i.e. the incremental compiler has some issues with Vue which we hope will be solved by this PR:

#220

In the meantime, you could fix it by forcing the Vue tests that are failing to not use the incremental API. That would work for now. Sound good?

Actually - better idea: could you apply the changes from this commit to your PR: 90836f2 (apart from the reasons.md that is). That should stop the incremental API being used and the tests should pass.

@yanivefraim
Copy link
Contributor Author

Actually - better idea: could you apply the changes from this commit to your PR: 90836f2 (apart from the reasons.md that is). That should stop the incremental API being used and the tests should pass.

@johnnyreilly - I cherry-picked 90836f2, without the readme part, wasn't sure about tests, so I just kept them...

@johnnyreilly
Copy link
Member

Awesome. Thanks!

Could you increment the version in the package.json and put an entry in the CHANGELOG.md please? I'll then merge and push out a release

@yanivefraim
Copy link
Contributor Author

Could you increment the version in the package.json and put an entry in the CHANGELOG.md please? I'll then merge and push out a release

@johnnyreilly - done

@johnnyreilly johnnyreilly merged commit 2dad936 into TypeStrong:master Mar 4, 2019
@johnnyreilly
Copy link
Member

Thanks!

@johnnyreilly
Copy link
Member

@yanivefraim yanivefraim deleted the useTypescriptIncrementalApi branch March 4, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: useTypescriptIncrementalApi flag is not true by default, even if TS Version > 3
2 participants