feat(DTFS2-7052): comments copy and variable name improvements

UK-Export-Finance · Apr 25, 2024 · 5a0ee93 · 5a0ee93
1 parent 75b34ac
commit 5a0ee93
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/helper-modules/ordnance-survey/ordnance-survey.service.ts b/src/helper-modules/ordnance-survey/ordnance-survey.service.ts
@@ -25,7 +25,6 @@ export class OrdnanceSurveyService {
       path,
       headers: { 'Content-Type': 'application/json' },
       onError: (error: Error) => {
-        console.error('Http call error happened, error %o', error);
         throw new OrdnanceSurveyException('Failed to get response from Ordnance Survey API.', error);
       },
     });

diff --git a/src/modules/geospatial/geospatial.service.ts b/src/modules/geospatial/geospatial.service.ts
@@ -18,7 +18,7 @@ export class GeospatialService {
     }
 
     response.results.forEach((item) => {
-      // Item can have key DPA or LPI, get data dynamically, even if we expect key to always be DPA.
+      // Item can have key DPA or LPI, so we get data dynamically, even if we expect key to always be DPA.
       const item_data = item[Object.keys(item)[0]];
       addresses.push({
         organisationName: item_data.ORGANISATION_NAME || null,

diff --git a/test/support/generator/get-geospatial-addresses-generator.ts b/test/support/generator/get-geospatial-addresses-generator.ts
@@ -109,7 +109,7 @@ export class GetGeospatialAddressesGenerator extends AbstractGenerator<AddressVa
       ],
     }));
 
-    const getAddressesOrdnanceSurveyMultipleResponse: GetAddressesOrdnanceSurveyResponse = {
+    const getAddressesOrdnanceSurveyMultipleMatchingAddressesResponse: GetAddressesOrdnanceSurveyResponse = {
       header: {
         uri: 'test',
         query: 'test',
@@ -195,7 +195,7 @@ export class GetGeospatialAddressesGenerator extends AbstractGenerator<AddressVa
       getAddressByPostcodeMultipleResponse: getAddressesByPostcodeMultipleResponse,
       getAddressOrdnanceSurveyResponse: getAddressesOrdnanceSurveyResponse,
       getAddressOrdnanceSurveyEmptyResponse: getAddressesOrdnanceSurveyEmptyResponse,
-      getAddressOrdnanceSurveyMultipleResponse: getAddressesOrdnanceSurveyMultipleResponse,
+      getAddressOrdnanceSurveyMultipleResponse: getAddressesOrdnanceSurveyMultipleMatchingAddressesResponse,
       ordnanceSurveyAuthErrorResponse,
     };
   }