Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-12005 Include slicemetadata in makerbot file #19355

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Jul 10, 2024

Include the very same file as generted into UFP files. The existing export method has been moved from UFPWriter top API/Settings in order to make it easily callable by the two plugins.

⚠️ In the makerbot archive, the file is placed at the root with the other files, because there is no folder structure. In the UFP this file is placed in the Cura subfolder.

CURA-12005

Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work -- -w --color-moved made it really clear that the change is basically just a move 😁

Not only is this more congruent with the file-format as it exists, the Digital Library handles the metadata in this format, and can do little with it otherwise.

last step needed for CURA-12005
@rburema rburema changed the base branch from 5.8 to main August 1, 2024 13:31
@HellAholic HellAholic merged commit 7da71d6 into main Aug 6, 2024
11 checks passed
@rburema rburema deleted the CURA-12005_include_slicemetadata_in_makerbot_file branch August 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants