Add local_files_only parameter to load_from_checkpoint method #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
local_files_onlyparameter toload_from_checkpointmethod as discussed in #225The
local_files_onlyparameter is created in the constructor of each encoder and CometModel.I found that even after downloaded a ckpt file (such as Unbabel/wmt22-comet-da),
pretrained_modelspecified in checkpoint's hparams.yaml should also be downloaded to use tokenizer. So I wrote it in docstring inload_from_checkpoint.Please let me know if there is anything to be fixed 😃