Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify nodejs and npm versions #1617

Closed
pciavald opened this issue Mar 27, 2021 · 6 comments
Closed

specify nodejs and npm versions #1617

pciavald opened this issue Mar 27, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@pciavald
Copy link
Contributor

Is your feature request related to a problem? Please describe.

it seems we've encountered errors because we're using npm 6.14.11 and you're probably using npm 7 as the package-lock.json says lockfileVersion: 2

Describe the solution you'd like

in CONTRIBUTING.md, could you please add the npm and nodejs versions you are using to do the builds ?

@pciavald pciavald added the enhancement New feature or request label Mar 27, 2021
@pciavald
Copy link
Contributor Author

pciavald commented Apr 7, 2021

I still have a difference from your setup i think, see the difference of package-lock.json in #1610

@UnchartedBull
Copy link
Owner

Which os are you using? Different operating systems can cause differences in the package-lock iirc.

@pciavald
Copy link
Contributor Author

pciavald commented Apr 7, 2021

Fedora 33 workstation

@UnchartedBull
Copy link
Owner

I'm using a Mac so that is probably why there are still some differences. I think we can safely ignore those though.

@pciavald
Copy link
Contributor Author

pciavald commented Apr 7, 2021

until we find out, i think it's best that when you merge a PR that modifies package.json, you run npm install and commit package-lock.json before merging

@UnchartedBull
Copy link
Owner

Sounds like a plan 👍

pciavald pushed a commit to pciavald/OctoDash that referenced this issue May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants