Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom action for controlling Enclosure plugin outputs is missing #1846

Closed
haplm opened this issue May 22, 2021 · 3 comments · Fixed by #2094
Closed

Custom action for controlling Enclosure plugin outputs is missing #1846

haplm opened this issue May 22, 2021 · 3 comments · Fixed by #2094
Assignees
Labels
bug Something isn't working
Milestone

Comments

@haplm
Copy link

haplm commented May 22, 2021

Describe the bug
As discussed on Discord, the problem is that setOutput() method for the Enclosure plugin has no associated custom action, hence it can't be used from the UI.

Related ticket is #1123.

Expected behavior
I could set one of the Enclosure plugin outputs using a custom action.

@ab-tools
Copy link
Contributor

While adding output support for the enclosure plug-in please also add support for PWM outputs of the enclosure plug-in as well (not just the regular outputs).

I've already created a pull request to add back-end support for this to the EnclosureService here:
#1848

@UnchartedBull
Copy link
Owner

Will do, should be released with v3.0.0.

@UnchartedBull UnchartedBull added this to the v3.0.0 milestone May 25, 2021
@UnchartedBull
Copy link
Owner

https://github.com/UnchartedBull/OctoDash/wiki/Custom-Actions#predefined-actions wiki has been updated as well. Will be part of next release. If you can't wait feel free to build from main once the linked PR has been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants