Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PWM Outputs of Enclosure Plug-In #1848

Merged
merged 4 commits into from
May 26, 2021
Merged

Support PWM Outputs of Enclosure Plug-In #1848

merged 4 commits into from
May 26, 2021

Conversation

ab-tools
Copy link
Contributor

This adds back-end support for PWM outputs to the EnclosureService.

Please also consider enclosure plug-in PWM outputs while working on #1846.

@ab-tools ab-tools mentioned this pull request May 23, 2021
Closed
UnchartedBull
UnchartedBull approved these changes May 25, 2021
View reviewed changes
Copy link
Owner

@UnchartedBull UnchartedBull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :)

@UnchartedBull
Copy link
Owner

UnchartedBull commented May 25, 2021 •
edited
Loading

Please make sure that your Code adheres to the style guidelines (npm run lint), so the pipeline also gives green light :)

@ab-tools
Copy link
Contributor Author

The one variable should be adjusted to camel case now.

@UnchartedBull UnchartedBull merged commit 1f15885 into UnchartedBull:main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnchartedBull UnchartedBull UnchartedBull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ab-tools @UnchartedBull