Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OctoPrint Push Update (DisplayLayerProgress optional) #595

Closed
RC-Thoughts opened this issue Apr 25, 2020 · 12 comments · Fixed by #1438
Closed

OctoPrint Push Update (DisplayLayerProgress optional) #595

RC-Thoughts opened this issue Apr 25, 2020 · 12 comments · Fixed by #1438
Assignees
Labels
enhancement New feature or request
Projects

Comments

@RC-Thoughts
Copy link

It would be nice to see the current height (Z) while printing, for example to the right of "Layer xx / yy".
It's available from current payload as "currentZ", I'm assuming printerstate is already being used so implementation should not be to hard?

@RC-Thoughts RC-Thoughts added the enhancement New feature or request label Apr 25, 2020
@UnchartedBull
Copy link
Owner

Is that available via the DLP plugin or does OctoPrint sent those values natively?

I don‘t want to clutter up the UI too much, but I‘ll have a look and see, whether this is possible to integrate.

@RC-Thoughts
Copy link
Author

It's available as push update: https://docs.octoprint.org/en/master/api/push.html?highlight=currentZ

@whoim2
Copy link

whoim2 commented Apr 27, 2020

Good idea, and add babystepping on job ajust screen. Customizable babystep commands, for use marlin and klipper.

@UnchartedBull
Copy link
Owner

DIdn't know that the push update even existed. Did you have any experience with this? It looks super promising from the docs, so I might just replace all the GET requests with this push API in the near future (after v2 release though) ...

@whoim2 As I said above I have to see if and how it fits in the current design. I'll have a look at that :)

@UnchartedBull UnchartedBull changed the title Current height (Z) in printing status? Current height in printing status / OctoPrint Push Update Apr 27, 2020
@UnchartedBull UnchartedBull self-assigned this Apr 27, 2020
@UnchartedBull UnchartedBull added this to To do in Future via automation Apr 27, 2020
@RC-Thoughts
Copy link
Author

I have not tried it, I just got my environment to compile Octodash so I can do some small things to my taste :)

@UnchartedBull
Copy link
Owner

That‘s great! Let me know if you need help with anything :)

@jalanjarosz
Copy link

jalanjarosz commented Apr 30, 2020 via email

@RC-Thoughts
Copy link
Author

One interesting way could be to send M114 and parse the respond with regexp like X:([-+]?[0-9.]+) Y:([-+]?[0-9.]+) Z:([-+]?[0-9.]+) E:([-+]?[0-9.]+) I don't think ti will be too much of time consuming to use it like every 10 sec or so. I need to play around with that a bit some day.

@UnchartedBull UnchartedBull changed the title Current height in printing status / OctoPrint Push Update OctoPrint Push Update (DisplayLayerProgress optional) Jun 6, 2020
@NickRno77
Copy link

NickRno77 commented Jul 25, 2020

would it be possible to disable DisplayLayerProgress Plugin from OctoDash, I've disabled app on OctoPrint and constantly get messaged telling me that DisplayLayerProgress I not installed. I've tried editing the .config/octodash/config.json and changing DLP line to false but still get error.

I actually found this DLP issue......
#584

@UnchartedBull
Copy link
Owner

Once this is merged DLP will be optional, until then it is definitely needed, since there is no way to get the Z-Height from the API. In the linked issue should be a custom build with DLP disabled though (no layer indication and fan speed).

@UnchartedBull UnchartedBull removed this from To do in Future Aug 19, 2020
@UnchartedBull UnchartedBull added this to To do in v3 Release via automation Aug 19, 2020
@UnchartedBull UnchartedBull moved this from To do to In progress in v3 Release Oct 26, 2020
@jneilliii
Copy link
Contributor

jneilliii commented Dec 21, 2020

If it helps any @UnchartedBull I believe OctoFarm uses the websocket approach. Maybe something to look at as an example implementation.

https://github.com/NotExpectedYet/OctoFarm

I think the meat of it can be found here.

@UnchartedBull
Copy link
Owner

Thanks for the link. I already have a POC with the connection up and running. Will be hopefully done soonish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v3 Release
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants