Update install.sh #1157
Merged
Update install.sh #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addd multi arch support to installer script.
Added additional deps reported here (https://github.com/UnchartedBull/OctoDash/wiki/Troubleshooting#not-starting-automatically)
Closed
There was a problem hiding this comment.
looks good. one minor thing maybe:
I think it would be great if you could save the architecture to a string, rather than echoing it directly to the console. Then include that string in the Installing OctoDash part. Final output could look something like this:
Installing OctoDash (v2.1.1, armv7l). What do you think about that?
You can ignore the CodeFactor issue btw.
Added arch info to Installing OctDash echo line, and removed arch echos.
|
Tested, and this should be working now. |
forgot comma
Made sure that all echo "Installing OctoDash..." along w/ final echo of successful install provided version and arch info
|
Fixes #1156. |
Corrected missing " in echo lines. Removed version and arch from last echo line.
UnchartedBull
approved these changes
Nov 9, 2020
kantlivelong
pushed a commit
to kantlivelong/OctoDash
that referenced
this pull request
May 5, 2021
* Update install.sh Addd multi arch support to installer script. * Update install.sh Added additional deps reported here (https://github.com/UnchartedBull/OctoDash/wiki/Troubleshooting#not-starting-automatically) * Update install.sh Added arch info to Installing OctDash echo line, and removed arch echos. * Update install.sh forgot comma * Update install.sh Made sure that all echo "Installing OctoDash..." along w/ final echo of successful install provided version and arch info * Update install.sh Corrected missing " in echo lines. Removed version and arch from last echo line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi arch support to installer script.