Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbz theme updates #1161

Merged
merged 8 commits into from
Nov 9, 2020
Merged

Conversation

thegarbz
Copy link
Collaborator

@thegarbz thegarbz commented Nov 8, 2020

A couple of tweaks to the other two themes, a new theme, and since I have a few in the folder now I added an index file.

Adjusted spacing between the layer indicator and
the printer status as they slightly overlaped.
A new theme modified from the NOX theme but with a focus
on critical values, and with large horizontal and circular
progress bars.
Changed size of the hitbox around settings icon to make easier to hit.
Copy link
Owner

@UnchartedBull UnchartedBull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes. Should be good to go afterwards.

themes/theGarbz/Focus/README.md Outdated Show resolved Hide resolved
```
~/.config/octodash/custom-styles.css
```

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Pi are you running this theme on? I noticed on the OG Raspberry Pi 3 the blur effect really takes a hit on performance. Might be worth adding as a heads-up here for other users (same would need to be added to the NOX theme then of course).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I've noticed it wasn't quite as smooth but I didn't know why, and it's not really terrible performance just a little bit of stutter. I'm running on a Raspberry Pi 4. I added a warning commit abfc903

I also fixed a misaligned element in another commit but hopefully we should be finished now.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UnchartedBull UnchartedBull merged commit 7fd1d27 into UnchartedBull:master Nov 9, 2020
@thegarbz thegarbz deleted the garbz-themeupdates branch November 10, 2020 00:14
kantlivelong pushed a commit to kantlivelong/OctoDash that referenced this pull request May 5, 2021
* Glanceable - Fixed layer spacing
Adjusted spacing between the layer indicator and
the printer status as they slightly overlaped.

* Garbz Theme Index

* New Theme "Focus"
A new theme modified from the NOX theme but with a focus
on critical values, and with large horizontal and circular
progress bars.

* BigFingers settings hitbox incresaed
Changed size of the hitbox around settings icon to make easier to hit.

* Fix duplication error

* Added Link to NOX theme

* Performance Warning

* Focus: Fixed centering on percent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants