Add support for TPLinkSmartPlug plugin

[xunleii]

Add the support for TP Link as alternative of PSU Controler plugin (and fix the issue #1244).

It implements 2 custom actions ([!TPLINKOFF] and [!TPLINKON]) and an option to power on the smartplug when the standby mode exits. I tested these changes on my RPi 3B (and on my laptop) and it seems working without any issues (this is barely a copy/paste of the PSU plugin, without the toggle feature).

Unfortunately, we need a keyboard to setup the IP address in the settings menu (or edit the config.json file).

Closes #1244

[UnchartedBull]

Thank you for your contribution! This looks really promising. I'm kind of busy right now, so it probably will take me a day or two to review this. But from a first glance everything looked alright!

[UnchartedBull]

Really solid PR for a highly requested feature. Thank you so much!

I just have one really minor issue with this, with your changes the turnOnPowerWhenExitingSleep will exist twice which might be a bit confusing to some users. I'd prefer if we keep the already existing attribute and then just check whether TPLink SmartPlug Plugin is enabled (then use the TPLink SmartPlug) or not (then use PSUControl). I proposed some changes (altough not tested), but they should work I think. Let me know if you have any objections on removing turnOnPowerWhenExitingSleep from the TPLink Plugin :)

edit: Might be a good idea to rename the toggle to turn on power when exiting sleep (on the UI side should be more than enough) to make it less confusing.

[xunleii]

Really solid PR for a highly requested feature. Thank you so much!

I just have one really minor issue with this, with your changes the turnOnPowerWhenExitingSleep will exist twice which might be a bit confusing to some users. I'd prefer if we keep the already existing attribute and then just check whether TPLink SmartPlug Plugin is enabled (then use the TPLink SmartPlug) or not (then use PSUControl). I proposed some changes (altough not tested), but they should work I think. Let me know if you have any objections on removing turnOnPowerWhenExitingSleep from the TPLink Plugin :)

edit: Might be a good idea to rename the toggle to turn on power when exiting sleep (on the UI side should be more than enough) to make it less confusing.

Yep, it looks better to have only one button to do that. Moreover, it allows us to extends OctoDash with another PSU plugin more easier in the future ^^. I will apply these changes and test it today.

Also, I have an idea for this option; What about moving the option turnOnPSUWhenExitingSleep directly in the plugin settings (not affiliated to a specific plugin like PSUControl) ? I think it will be less confusing because, when we use the TPLink plugin, we need to toggle an option on the PSUControl settings.

Thanks a lot for your review.

[xunleii]

After testing with suggestion, moving the turnOnPSUWhenExitingSleep option as affiliated options make more sense; currently, we need to enable PSUControl plugin to toggle turnOnPSUWhenExitingSleep option.

EDIT: I push a working draft of this idea. It also avoid breaking changes with the current PSUControl settings

[xunleii]

I have another issue ... when I upgrade from the last release to the next with my PR, the settings menu is broken. The only way I found to fix it is to add manually the TPLink plugin settings section inside the config.json file.

EDIT: I found why (I forgot a requirement in the config.schema.ts) ... but now, I have the error message Your config is invalid! because the plugin settings doesn't exists inside the config file. Is it a way to autofix this ?
Fixed using the autofix mecanism (a bit modified to "autofix" only invalid parameters)

[UnchartedBull]

That migrate function is awesome! That is something that I've been wanting to do from the beginning but didn't really know how to tackle. Thanks for cleaning that up and making future config changes a lot easier!

I feel bad to request some more changes, but I think the migratePSUControl is better fitted in your new awesome migrate function! After that this is ready to be merged and will then be included in the next release :)

[xunleii]

All is fixed. I also use the optional chaining in getErrors to avoid null exception when no error are found (and update the valid field when the configuration is updated, because it is only set during the init ... which is false before autofixing then true if all errors are fixed).

Thanks for your review and your suggestions.

[UnchartedBull]

🚢