Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n + FR #1610
i18n + FR #1610
Changes from 38 commits
0e42520
79f5a25
2991cd3
5f45a66
42fd53a
7fe0d10
d0f5b97
5a17b8d
5455084
58bfd22
e85b3ec
ff7648a
aca0c8b
989c3a7
50a6370
77fe58c
2032b28
c25edcb
225c7b3
a33ea6e
c3dcd51
165510f
7394404
e8552c8
c6673d5
f5cb861
e28498e
56cfc57
e4c400b
4bd4017
97b8477
07e999e
e538f80
f9be03f
e5a3166
2e3105c
c55ecf9
c988918
4a7c8b3
7a97c24
15472b4
7e7b431
24760f4
38a2b08
66907de
44991c3
a3de092
8f57b66
04d2608
1b49d59
156fd4f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project also has lodash installed, maybe use deepCopy from lodash, might be a bit faster: https://lodash.com/docs/4.17.15#cloneDeep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using
const _ = require('lodash-es');
i getusing
import _ from 'lodash-es';
i getIs it worth investigating further and probably packaging a new module ?