E movement

[pciavald]

This is how we implement it for us. I needed to refactor to flexbox (#1622) for easier enabling/disabling of the component. Feel free to just close if you don't want it in upstream, or use only the flexbox refactor.

• implement new configuration showExtruderControl defaulting to false
• control extrusion in control component if showExtruderControl set to true in user config

Fixes #1591
Closes #1883

[pciavald]

It all works, but i still see this error clearly related to my usage of the configService, i guess i missed something to load the service properly ?

[UnchartedBull]

Great idea to make this configurable! Then there is nothing in the way of merging this into main. Just two little things:

• If you add new config options please make sure to also include them here: https://github.com/UnchartedBull/OctoDash/blob/main/src/app/app.service.ts#L30. This will then automatically upgrade the config if a user upgrades OctoDash. I think in this case it would definitely make sense to add this attribute there and set it to false by default.
• I think it might be nice to replace the icons, this would make it easier to differentiate between Z-Axis Control and Extruder Control without having to read the text. What do you think of undo-alt (https://fontawesome.com/icons/undo-alt?style=solid) for retracting and redo/alt(https://fontawesome.com/icons/redo-alt?style=solid) for extruding?

The config error should only show up if the devTools reload your app. The problem here is that Angular somehow skips the initialisation process if a different view than mainView is open. This shouldn't happen on the Pi, since the UI is not being reloaded there. So nothing to worry about :)

[pciavald]

Thanks, I'll check that! Glad you like the idea of making it configurable!

About the new config i was thinking to let it optional and not include it in the config, only setting the default value to false. This way when a config does not have the property, it does not get in the way, otherwise it can be set to false (no effect) or true. Do you prefer adding them to false anyway ?

[UnchartedBull]

Oh I see how this is working now. That's definitely a creative way to exploit the lazy type checking of JS :D.

Would be great if this could be a required part of the config, just to make everything a bit more consistent (should only be two lines of code to add this attribute during upgrades). Thanks! :)

[pciavald]

will do!

[pciavald]

I've just noticed that this may break themes.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[pciavald]

note to self: pushed this branch to upstream in order to rebase #1895 on it

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.