package fonts #1654
Merged
package fonts #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to merge |
UnchartedBull
approved these changes
May 11, 2021
|
The svg logo isn't working. Going to revert to the normal text-based logo, the local fonts are a nice addition though. It also doesn't scale well on different resolutions.
|
|
@UnchartedBull Ooops, i did not see that! Can i still try to fix it? |
|
Sure feel free to create another PR for that. |
pciavald
added a commit
to pciavald/OctoDash
that referenced
this pull request
May 12, 2021
* add typos, replace html logo by svg * fix css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes octodash's logo on the main-menu, replacing the hard-coded HTML version of the logo by a SVG logo.
It also packages the fonts as OctoDash may not always be connected to internet, and getting the fonts from google in index.html may then not always work.
Note: may break themes