Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors and unnecessary data shown when printing from SD #542

Merged

Conversation

harleyg321
Copy link
Contributor

When printing from SD, a thumbnail image should not be retrieved as the filename does not exist in OctoPrint.

Null values should be propagated through to the view instead of replaced with 0. This way values which are not available when printing from SD (listed below, or any other situation also resulting in it being null) can be hidden.

  • Filament used
  • Time remaining, until OctoPrint has estimated a time remaining based on current print progress, otherwise it shows 0 remaining for the first minute or so of printing, which looks odd
  • Layer progress, which shows as layer 0 of 0

Fixes #541

@UnchartedBull
Copy link
Owner

OctoDash doesn't support SD Card Files (since it's always a big hassle with the GCode information and stuff), that's why I haven't really checked those things. But this is a great compromise I think!

@UnchartedBull UnchartedBull merged commit defbb93 into UnchartedBull:master Apr 3, 2020
@harleyg321 harleyg321 deleted the fix/printing_from_sd branch April 9, 2020 08:51
@harleyg321 harleyg321 mentioned this pull request Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors received when printing from sd
2 participants