-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting idempotents #1105
Splitting idempotents #1105
Conversation
…is-quasiidempotent`
Since I won't be able to finish this PR before I leave tomorrow, let me write down some thoughts here for when I pick this up again.
It's sensible to make a new file for infinitely coherent idempotent maps, but then one may ask if the proof that quasiidempotents split fits better in that file. There is also a question of whether we want more agda-unimath like names for
Any other nice and easy consequences of this formalization? |
I also need to verify that the diagrams render properly |
To partition this work up a bit, I may aim to formalize fully coherent idempotents in a subsequent PR. It still remains to tidy up this PR before it is ready for review, however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice pull request, with many excellent new additions. Thank you so much for making this effort Fredrik!
Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to see this formalized, @fredrik-bakke!
Is this PR ready to merge? I can formalize the counter-example in a subsequent PR thanks to #1115 |
Great work, I'll turn on the auto-merge |
Summary
Work towards #1103.