-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor graphs with updates from Beyond finite sets #879
base: master
Are you sure you want to change the base?
Conversation
has-decidable-equality-walk-Undirected-Graph-𝔽 : | ||
{x y : vertex-Undirected-Graph-𝔽 G} → | ||
has-decidable-equality (walk-Undirected-Graph-𝔽 G x y) | ||
has-decidable-equality-walk-Undirected-Graph-𝔽 {x} {.x} | ||
refl-walk-Undirected-Graph w = | ||
{!!} | ||
has-decidable-equality-walk-Undirected-Graph-𝔽 {x} {._} | ||
( cons-walk-Undirected-Graph p e v) w = | ||
{!!} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work in progress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I left some holes. Gotta fix that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to merge this PR as I thought this was cleaned up. But I see this still isn't, so I'll leave it for you to finish first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me aside from my few comments
Co-authored-by: Fredrik Bakke <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
Your comments look good too |
Thanks! I wrote them just for you :) |
This PR refactors the graph theory library with updates from the Beyond Finite Sets PR.