Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat [close #310]: Mounts system mountpoints like /home and /etc before systemd starts #316

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

taukakao
Copy link
Member

Fixes #310

This command replaces the systemd mount units with a command that has to be run before systemd.
This ensures that systemd recognizes the correct state of /etc.
This also makes the system more predictable, since there's not two different /etc folders to worry about.

To migrate to this version, the init system has to call the two new abroot functions before executing systemd.
The systemd mount units of old abroot versions don't cause any problems, since systemd doesn't remount them, so no futher migration is needed.

@taukakao
Copy link
Member Author

Also, I can squash the commits if it's necessary but I think these commits are already pretty atomic.

Copy link
Member

@matbme matbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good. My spam of suggestions is mostly related to missing translations.

cmd/unlock-var.go Outdated Show resolved Hide resolved
cmd/unlock-var.go Show resolved Hide resolved
cmd/unlock-var.go Show resolved Hide resolved
cmd/unlock-var.go Show resolved Hide resolved
cmd/unlock-var.go Show resolved Hide resolved
cmd/mount-sys.go Show resolved Hide resolved
cmd/mount-sys.go Show resolved Hide resolved
cmd/mount-sys.go Show resolved Hide resolved
cmd/mount-sys.go Show resolved Hide resolved
cmd/mount-sys.go Show resolved Hide resolved
@matbme matbme changed the title fix [#310]: Mounts system mountpoints like /home and /etc before systemd starts feat [close #310]: Mounts system mountpoints like /home and /etc before systemd starts Jul 11, 2024
Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with Mat about the missing translations, but per our conversation on discord, should be fine due to the command being strictly internal.

Anyway, adding the translation keys should not be so hard, so I'll leave the decision to you.

Since abroot now handles mounting before systemd, this is not required anymore.
@taukakao
Copy link
Member Author

As discussed on Discord, I don't want to put translations in.
These commands are not user-facing so they don't need to be translated. It would only put extra work on the translators without making a difference.

@taukakao taukakao requested a review from matbme July 11, 2024 19:42
@mirkobrombin
Copy link
Member

Not to go over Mat but given the discussions on Discord regarding the translations and given the resolution of the discussions, I still proceed with the merge without his confirmation.

@mirkobrombin mirkobrombin merged commit eeaad76 into Vanilla-OS:main Jul 12, 2024
2 checks passed
@taukakao taukakao deleted the mount-sys-command branch July 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systemd services get ignored
4 participants