Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add libasound2 to core image #75

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

fluoriteByte
Copy link
Contributor

This will help with apps that require libasound2 but dont explicitly depend on it

@fluoriteByte
Copy link
Contributor Author

Huh thats weird, it fails to install libasound2 in the build but people are able to install it on pico vso,
Can anyone explain to me why it does this?

@axtloss
Copy link
Member

axtloss commented Aug 9, 2024

Most likely because pico doesn't contain any package that depends on libasound2t64. But installing it in pico would then also break the core image build since it'd later on cause the same dependency issue

@mirkobrombin
Copy link
Member

mirkobrombin commented Aug 9, 2024

I had a similar issue with cups, installing the dependency manually fixed it, so maybe try to add libasound2t64 to the list.

@fluoriteByte
Copy link
Contributor Author

Added the thing

@fluoriteByte
Copy link
Contributor Author

fluoriteByte commented Aug 9, 2024

Wait it replaces the other one, so lets remove it

@fluoriteByte
Copy link
Contributor Author

fluoriteByte commented Aug 9, 2024

Since libasound2t64 provides libasound so i will remove the other one

@mirkobrombin
Copy link
Member

Looks like it worked. Can you squash everything into a single commit?

@fluoriteByte
Copy link
Contributor Author

I dont really know how to squash commits on github's mobile site, any help?

@mirkobrombin
Copy link
Member

You cannot squash from github itself, we can during the merge but it is not the ideal. Someone will pick the PR and squash them for you via the git CLI before merging

@GabsEdits GabsEdits changed the title Add libasound2 to core image feat: add libasound2 to core image Aug 9, 2024
@GabsEdits
Copy link
Member

Took care of the squashing, the pr is ready to be merged

@GabsEdits GabsEdits merged commit 996c4a4 into Vanilla-OS:dev Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants