-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add libasound2 to core image #75
Conversation
Huh thats weird, it fails to install libasound2 in the build but people are able to install it on pico vso, |
Most likely because pico doesn't contain any package that depends on libasound2t64. But installing it in pico would then also break the core image build since it'd later on cause the same dependency issue |
I had a similar issue with cups, installing the dependency manually fixed it, so maybe try to add |
Added the thing |
Wait it replaces the other one, so lets remove it |
Since libasound2t64 provides libasound so i will remove the other one |
Looks like it worked. Can you squash everything into a single commit? |
I dont really know how to squash commits on github's mobile site, any help? |
You cannot squash from github itself, we can during the merge but it is not the ideal. Someone will pick the PR and squash them for you via the git CLI before merging |
Took care of the squashing, the pr is ready to be merged |
This will help with apps that require libasound2 but dont explicitly depend on it