adjust workflows to new branch structure #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkobrombin
approved these changes
Aug 5, 2024
kbdharun
reviewed
Aug 5, 2024
kbdharun
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Hi, This must be addressed before merging:
The main branch has branch protection so direct commits won't work from GitHub actions so this must be updated to create a PR instead (since removing it isn't good practice). We can discuss other possible alternatives too.
|
Seems that implementing this correctly is pretty much impossible due to branch protection rules. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes make it possible to build main with the Vib Workflow by automatically changing the :dev tag to :main during building.
They also add a workflow to easily sync the main branch with the dev branch on demand, while checking if core image is up to date as well.
When this is trough, I will add these changes to the other images as well.