Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for opening terminal in nautilus #201

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

fluoriteByte
Copy link
Contributor

@fluoriteByte
Copy link
Contributor Author

from what i gleam from the logs, it seems to have skipped for some reason the module file i put there

@axtloss
Copy link
Member

axtloss commented Aug 10, 2024

You still have to tell it to include the module in the recipe.yml file

@fluoriteByte
Copy link
Contributor Author

oop lol

@fluoriteByte
Copy link
Contributor Author

Do i have to explicitly add make as an apt dep for this module? I guessed it might be available because of earlier modules that had it

@axtloss
Copy link
Member

axtloss commented Aug 10, 2024

technically it's not required, but it'd be better to have it in case earlier modules suddenly dont need it anymore

@fluoriteByte
Copy link
Contributor Author

Do you know why it failed? Cus im pretty sure make only gets cleaned at the end

@axtloss
Copy link
Member

axtloss commented Aug 10, 2024

https://github.com/Vanilla-OS/desktop-image/actions/runs/10327285133/job/28592228057?pr=201#step:12:8668
it cant find localization files, you have to run make build install schema

@axtloss
Copy link
Member

axtloss commented Aug 10, 2024

Also change the commit title to feat: add support for opening terminal in nautilus (see the contributor guidelines for further reference)

this adds the necessary files for setting up nautilus-open-any-terminal 
for use in VOS, it sets the default terminal to blackbox and enables the 
generic name
@axtloss
Copy link
Member

axtloss commented Aug 10, 2024

Thanks for the contribution!

@axtloss axtloss merged commit f33a0c1 into Vanilla-OS:dev Aug 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants