Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Eqtide-Thermint coupling so the CPL model can work with Thermint. #297

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

RoryBarnes
Copy link
Collaborator

Added clean exit if user tries to select CTL model with Thermint.

Added unit tests for the CPL model with Radheat and Thermint.

Proposed changes

Previously only the DB15 model, which should never be used, was coupled to ThermInt. This change adds CPL to that list.

Types of changes

What types of changes does your PR introduce to VPLanet?
Put an x in the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • New module (non-breaking change that adds a new module)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of the steps that are necessary before merging your PR.

  • I have added tests that prove my fix is effective or that my feature works
  • I have adhered to the Style or run the clang format code shown here
  • I have added necessary documentation (if appropriate)
  • I have run Valgrind on new tests to ensure no errors were found
  • (Optional) I have added an example showcasing the new change

Further comments

Added clean exit if user tries to select CTL model with Thermint.

Added unit tests for the CPL model with Radheat and Thermint.
Copy link

github-actions bot commented Jul 30, 2024

Test Results

19 599 tests   17 759 ✅  3m 21s ⏱️
     1 suites       0 💤
     1 files        16 ❌  1 824 🔥

For more details on these failures and errors, see this check.

Results for commit 0aaf16b.

♻️ This comment has been updated with latest results.

@RoryBarnes RoryBarnes merged commit cf99e6a into main Jul 30, 2024
1 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant