added separate tsconfig for enzyme inheriting project configuration #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created a second one because I didn't want the one we need for the ts-jest to conflict with the one you need to build the current package. "include": [
"postinstall/*.ts"
],and you only load the node libraries. Unit tests on an SPFx project need more than that/different things. So the reasons are:
|
|
Got it... makes sense and a good idea. I'm going to change what you've done though to make it clearer as right now /resources/tsconfig.json isn't obvious what it's used for. Thanks! |
|
Feel free to edit my PR. You should have permissions. |
andrewconnell
added a commit
that referenced
this pull request
Oct 14, 2019
- previous fix in 1.3.1 introduced regression - this configures ts-jest prepreocessor to use same TSC compiler options as the project, but makes one mod to address issue that was fixed in 1.3.1 - incorporates fix submitted in PR #10, but implemented in a different way
|
Closing due to being outdated. Great suggestion and used it as the baseline for the fix in v1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids having lots of issues when trying to run unit tests