Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude template DBs from discovery and schema-qualify discovery query #50

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Exclude template DBs from discovery and schema-qualify discovery query #50

merged 2 commits into from
Jun 18, 2024

Commits on Jun 17, 2024

  1. pg_exporter: Harden queries against pg_database 

    Schema-qualify all object references in queries to `pg_database`.
    @ringerc
    ringerc committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d9e5d1a View commit details
    Browse the repository at this point in the history

  2. pg_exporter: Always exclude template dbs 

    When doing database auto-discovery, exclude all databases marked as
templates and any databases that do not allow connections.

It's conceivable, but not very likely, that someone could want to scrape
metrics from a template DB, but pg_exporter currently defaults to
excluding template1 anyway. postgres_exporter also has the same
behaviour of excluding template DBs from discovery. So I did not add a
CLI option to override this behavour.
    @ringerc
    ringerc committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ceed3e8 View commit details
    Browse the repository at this point in the history