Switch from unmaintained lib/pq driver to pgx with stdlib wrapper #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver github.com/lib/pq states that it is in maintenance mode. pgx offers built-in connection pooling and much more, and is actively maintained. The default URI postgresql:///?sslmode=disable will work out of the box with a unix socket connection, or one can be specified with e.g. -u 'postgres://postgres@:/?sslmode=disable&host=/var/run/postgresql' It's possible that some driver-specific options may vary, so this merits more testing. It should be possible to make it a CLI option and mark lib/pq deprecated rather than switching immediately, if that is deemed necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver github.com/lib/pq states that it is in maintenance mode.
pgx offers built-in connection pooling and much more, and is actively maintained.
The default URI postgresql:///?sslmode=disable will work out of the box with a unix socket connection, or one can be specified with e.g. -u 'postgres://postgres@:/?sslmode=disable&host=/var/run/postgresql'
It's possible that some driver-specific options may vary, so this merits more testing. It should be possible to make it a CLI option and mark lib/pq deprecated rather than switching immediately, if that is deemed necessary.