Action_built: Add unittest for percentage lookup #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
approved these changes
Mar 29, 2024
src/action/action_built.cpp
Outdated
| @@ -323,6 +323,10 @@ void COrder_Built::AiUnitKilled(CUnit &unit) | |||
|
|
|||
| static std::size_t FindCFramePercent(const std::vector<CConstructionFrame> &cframes, int percent) | |||
| { | |||
| if (cframes.empty()) | |||
| { | |||
| return -1; | |||
There was a problem hiding this comment.
returning std::optional<std::size_t> might be an option. that ensures the test for validity.
.editorconfig
Outdated
| @@ -8,6 +8,7 @@ root = true | |||
| charset = utf-8 | |||
| end_of_line = lf | |||
| insert_final_newline = true | |||
| trim_trailing_whitespace = true | |||
There was a problem hiding this comment.
Better to split PR next time.
| { | ||
| const int progressOnePercent = unit.Type->Stats[0].Costs[TimeCost] * 6; | ||
| return testUpdateConstrFrame_Progress(unit, percent * progressOnePercent, initialFrame); | ||
| } |
Comment on lines
59
to
60
| void setFrames(std::vector<CConstructionFrame> &cframes, | ||
| const std::vector<std::pair<int, int>>& vec) |
There was a problem hiding this comment.
Would std::vector<CConstructionFrame> makeFrames(const std::vector<std::pair<int, int>>& vec) make sense instead?
There was a problem hiding this comment.
changed. But does not look too different.
zzam
force-pushed
the
action_built_add_test
branch
from
7b835dd
to
a044616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the percentage lookup code fixed some days ago.
TODO: What else to test in here? and how?