Pathfinding #651
Merged
Pathfinding #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `CostMoveToCallBack_Default` multiplied cost by unitSize - `CostToGoal` < 16 was ignored - Increase `AStarMaxSearchIterations` (1024 is around 30x30)
zzam
reviewed
Apr 6, 2024
| // of the libc we're using has a 128/256/512bit SIMD vector | ||
| // instruction branch, since we might be clearing 8M of | ||
| // memory for a 2048x2048 map | ||
| alignas(64) int32_t CostFromStart = 0; /// Real costs to reach this point |
There was a problem hiding this comment.
Is the goal to align struct Node to 64 bytes?
pahole shows that sizeof(Node) is 64 now (instead of 8).
Isn't the allocator behind vector itself doing a larger alignment for larger allocations?
pahole:
struct Node {
private:
int32_t CostFromStart __attribute__((__aligned__(64))); /* 0 4 */
uint16_t CostToGoal; /* 4 2 */
int8_t InGoal; /* 6 1 */
int8_t Direction; /* 7 1 */
/* size: 64, cachelines: 1, members: 4 */
/* padding: 56 */
/* forced alignments: 1 */
} __attribute__((__aligned__(64)));
There was a problem hiding this comment.
Was indeed to not loose aligned_malloc(64, AStarMatrixSize).
But indeed I did it wrongly.
I think alignas(std::uint64_t) was enough, or even no alignment at all.
I will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve/fix pathfinding with big unit.