Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

160 sign in fixes: navigate to Dashboard when clicking magic link and added sign out button #167

Merged
merged 10 commits into from
Jul 23, 2024
Merged

160 sign in fixes: navigate to Dashboard when clicking magic link and added sign out button #167

merged 10 commits into from
Jul 23, 2024

Conversation

acao22
Copy link
Collaborator

@acao22 acao22 commented Jul 19, 2024

160 sign in fixes: navigate to Dashboard when clicking magic link and added sign out button

Description: This PR closes out most of the items on issue #160. Here are my changes:

  1. Directly navigate to Dashboard when a user clicks on the magic link instead of back to the sign in screen. There are a few instances where a notification pops up saying that the magic link is expired or incorrect when the website actually logs you in successfully, but I think that might be a different error (maybe related to issue When entering an email address to sign up, nothing appears to happen, and you are sent to the start of the survey #125 ) or just something different between production and dev mode
  2. Added a signout button in Dashboard.tsx under settings
  3. Added button styling (border, hover, and some drop shadow) for the signout and delete account buttons in settings so that users know it is clickable

@acao22 acao22 requested a review from amirrr July 19, 2024 17:21
@acao22 acao22 added bug Something isn't working enhancement New feature or request labels Jul 19, 2024
@acao22 acao22 self-assigned this Jul 19, 2024
amirrr
amirrr previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@amirrr amirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

client/public/locales/en/translation.json Show resolved Hide resolved
client/src/components/Enter.tsx Outdated Show resolved Hide resolved
@cypress Cypress
Copy link

cypress bot commented Jul 20, 2024 •
edited
Loading

Passing run #91 ↗︎

0 11 0 0 Flakiness 0

Details:

Merge pull request #167 from Watts-Lab/160-signin-flow-angie
Project: Commonsense Commit: ceaa98cb72
Status: Passed Duration: 00:44 💡
Started: Jul 23, 2024 7:23 PM Ended: Jul 23, 2024 7:24 PM

Review all test suite changes for PR #167 ↗︎

@JamesPHoughton JamesPHoughton mentioned this pull request Jul 22, 2024
Open
@acao22 acao22 requested a review from amirrr July 22, 2024 14:27
@acao22 acao22 enabled auto-merge July 23, 2024 03:57
@acao22 acao22 merged commit ceaa98c into main Jul 23, 2024
2 checks passed
@acao22 acao22 deleted the 160-signin-flow-angie branch July 23, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirrr amirrr amirrr approved these changes

Assignees

@acao22 acao22

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acao22 @amirrr