Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bad behaviors. #76

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

xiaoyu2006
Copy link

@xiaoyu2006 xiaoyu2006 commented Oct 22, 2022

@xiaoyu2006 xiaoyu2006 changed the title Fix various bad behavios. Fix various bad behaviors. Oct 22, 2022
@Boobies
Copy link

Boobies commented Dec 8, 2022

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@xiaoyu2006
Copy link
Author

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies

They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

@CaveNightingale
Copy link

CaveNightingale commented Dec 10, 2022

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies

They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem?
I have installed my branch on my server. However, I receive no bug report about end portal/

@xiaoyu2006
Copy link
Author

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies
They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem? I have installed my branch on my server. However, I receive no bug report about end portal/

With your latest commit (6e35f6a), I started a server and created an end portal. However by throwing items quickly into the portal (holding the Q button) from the overworld the stuff may duplicate. Throwing from the end to overworld may cause item loss.

@CaveNightingale
Copy link

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies
They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem? I have installed my branch on my server. However, I receive no bug report about end portal/

With your latest commit (6e35f6a), I started a server and created an end portal. However by throwing items quickly into the portal (holding the Q button) from the overworld the stuff may duplicate. Throwing from the end to overworld may cause item loss.

Can reproduce. Thanks for your reporting.

@CaveNightingale
Copy link

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies
They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem? I have installed my branch on my server. However, I receive no bug report about end portal/

With your latest commit (6e35f6a), I started a server and created an end portal. However by throwing items quickly into the portal (holding the Q button) from the overworld the stuff may duplicate. Throwing from the end to overworld may cause item loss.

Fixed.

@KLONOA9X6
Copy link

@CaveNightingale
Copy link

crash-2023-01-02_16.21.27-server.txt

I have no idea why you post this crash report here. Describe your problem if the crash report is relevant to the discussion.

@xiaofan7520
Copy link

crash-2023-01-02_16.21.27-server.txt

I have no idea why you post this crash report here. Describe your problem if the crash report is relevant to the discussion.

It's my server crash report. Mabe it's Issue #42

@EGOIST1372
Copy link

so does this commit gonna merge or not?
it seems fixes a lot of bugs

@CaveNightingale
Copy link

so does this commit gonna merge or not?
it seems fixes a lot of bugs

Probably not. This repo is not supported anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants