Fix incoming LID and sending LID

[PurpShell]

Big thank you to @canove and @whaticket for the help and resources.

This should fix chats incoming/outgoing with people with a hidden number.

If you'd like to thank me for my work, I have a GitHub Sponsors

[whiskeysockets-bot]

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@WhiskeySockets/Baileys#fix-lids
# YARN v2
yarn add @whiskeysockets/baileys@WhiskeySockets/Baileys#fix-lids

[azudindaem]

Has anyone tried it?

[takimtod]

Button support ?

Aduh sepuh bisa aja

[kyraex]

Anyone using normal whatsapp in this PR? I tested with mine but it throws failed to decrypt message error. There are no error with the current release

{"level":50,"time":"2023-10-04T18:39:00.738Z","pid":1112926,"hostname":"server","key":{"remoteJid":"[email protected]","fromMe":true,"id":"DA49097B5759A7F01865526B4966515B"},"err":{"type":"PreKeyError","message":"Invalid PreKey ID","stack":"PreKeyError: Invalid PreKey ID\n at SessionBuilder.initIncoming (/root/app_server/0/node_modules/libsignal/src/session_builder.js:66:19)\n at async Object.XXXX.0 [as awaitable] (/root/app_server/0/node_modules/libsignal/src/session_cipher.js:205:30)\n at async _asyncQueueExecutor (/root/app_server/0/node_modules/libsignal/src/queue_job.js:20:29)","name":"PreKeyError"},"msg":"failed to decrypt message"}

[Salientekill]

I can't download this update ;-;

NPM

npm install @whiskeysockets/baileys@WhiskeySockets/Baileys#fix-lids

YARN v2

yarn add @whiskeysockets/baileys@WhiskeySockets/Baileys#fix-lids

[azudindaem]

The masked number is from FB Ad Messages to WA Business. If you are using regular WhatsApp, this error is not related to this issue

[azudindaem]

Done a few testing on this PR.
Replicate test using actual FB Ads CTWA

Sending using @lid from Baileys to user - PASS
No more waiting for the message problem

RequestPhoneNumber - PASS
SharePhoneNumber - PASS

Receiving not appear in upsert event if user message - FAILED
Receiving not appear in upsert event after share number - FAILED

Test device -
WA Business 2.23.19.84

User 1: WA 2.23.20.74
User 2: WA Beta 2.23.21.7

Masked number only appear as privacy token

[PurpShell]

The masked number is from FB Ad Messages to WA Business. If you are using regular WhatsApp, this error is not related to this issue

in the future, we found traces that all businesses will talk to normal numbers through the LID. As a matter of fact, get a normal whatsapp lid right now, send a message to it through baileys in this PR through any business number. And you will not get their number, it'll be the same as the fb ads ctwa.

[PurpShell]

Also, I had no issues over dozens of numbers receiving and sending events and messages, check if anything is wrong with your configuration.

[kyraex]

Can we add lidJid as well in contacts.upsert here

            ev.emit('contacts.upsert', [{ id, name: action.contactAction!.fullName!, lidJid: action.contactAction!.lidJid! }])

[PurpShell]

no need, official whatsapp web launches a new conversation. it is up to you to change contact info or replace the chat id in your database.

[w3nder]

So far, so good. I managed to capture the event from the ads and also respond to that contact.

[fogolin]

Any news on this? Can an Admin review this PR, we actually need one more review for this to be approved.

[azudindaem]

@Auties00 we can approve this first then can be fixed later for user still not be able to detect conversion from lid

[w3nder]

up

[jaison-x]

fresh installed test on "@whiskeysockets/baileys": "github:WhiskeySockets/Baileys#fix-lids"

Sending using @lid from Baileys to user - PASS No more waiting for the message problem

RequestPhoneNumber - PASS SharePhoneNumber - PASS

Receiving not appear in upsert event if user message - FAILED

Could you help me how can I send/receive a message using @lid to test this PR? Thanks

[DavidsonGomes]

up

[diegovin16]

up

[T3uZ]

Up

[kyraex]

Have been testing this PR for a month and there isn't any breaking issue. +1 to merge this PR thanks!