fix: find platform type based on browser second argument

[allburov]

fix #481 #228

If we use

browser: ['MyAwesomeApp', 'chrome', '22.5.0']

WhatsApp shows the browser's icon in Linked Devices

[whiskeysockets-bot]

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@allburov/Baileys#get-browser-logo-back
# YARN v2
yarn add @whiskeysockets/baileys@allburov/Baileys#get-browser-logo-back

[FERDIZ-afk]

Can fi be used in the pairing code?

[azudindaem]

LGTM

[allburov]

The linter goes crazy about not changed code, idk what to do here. Let me know if I need to adjust the code somehow!

[CSFelix]

Great Job!!!! If it is possible, what do you think in adding two more browsers: Brave and Tor?

[Riders004]

Great Job!!!! If it is possible, what do you think in adding two more browsers: Brave and Tor?

Add. Firefox brave tor

[onurguven]

Lgtm

[allburov]

Brave and Tor

Is there any values for this browsers in WhatsApp proto? I didn't see it in the list

Baileys/WAProto/WAProto.proto

Lines 533 to 557 in e24947e

	enum PlatformType {
	UNKNOWN = 0;
	CHROME = 1;
	FIREFOX = 2;
	IE = 3;
	OPERA = 4;
	SAFARI = 5;
	EDGE = 6;
	DESKTOP = 7;
	IPAD = 8;
	ANDROID_TABLET = 9;
	OHANA = 10;
	ALOHA = 11;
	CATALINA = 12;
	TCL_TV = 13;
	IOS_PHONE = 14;
	IOS_CATALYST = 15;
	ANDROID_PHONE = 16;
	ANDROID_AMBIGUOUS = 17;
	WEAR_OS = 18;
	AR_WRIST = 19;
	AR_DEVICE = 20;
	UWP = 21;
	VR = 22;
	}

I'll change the solution as @Ismananda mentioned so we can define any values that available in proto!

[Riders004]

LGTM

What is LGTM

[Riders004]

Can this Working For Also For QR Code ?

@allburov

[Riders004]

Pair code mode not working with recent change

[allburov]

Pair code mode not working with recent change

Thank you for the information! To be honest, I haven't tested it :D

I've reverted the changes - we can process them later in the different PR and merge QR mode for now.

[allburov]

What is LGTM

looks good to me

[Riders004]

Pair code mode not working with recent change

Thank you for the information! To be honest, I haven't tested it :D

I've reverted the changes - we can process them later in the different PR and merge QR mode for now.

I'm qr is working but in pair its say incorrect code what I do

[Riders004]

@allburov This One Working On QR Code And Pair Code You Can Check Here And You Can Also Test It And You Can Make Pull Request

@adiwajshing @PurpShell @Auties00 @SheIITear @whiskeysockets-bot @FERDIZ-afk you can merge that request if @allburov he make it

[Ismananda]

I'm qr is working but in pair its say incorrect code what I do

Excuse me, I can see your socket configuration in the browser section
browser: ["device", "browser", "version"]

[Riders004]

I'm qr is working but in pair its say incorrect code what I do

Excuse me, I can see your socket configuration in the browser section browser: ["device", "browser", "version"]

That's my Browser Configuration and I also added in my Baileys that i added in my pair code script folder

If you want browser version then you can find on google

[Ismananda]

I'm qr is working but in pair its say incorrect code what I do

Excuse me, I can see your socket configuration in the browser section browser: ["device", "browser", "version"]

That's my Browser Configuration and I also added in my Baileys that i added in my pair code script folder

If you want browser version then you can find on google

I don't know for sure how it can be an error to you (because I actually don't really understand typescript)
But I use configuration like this browser: ["Mac OS", "Safari", clVer] and make an experiment by changing the code in node_modules/baileys as I said earlier and it work for me for qrcode and pairing code
So on the linked device you will see like this

[Ismananda]

So maybe it was unsuccessful because of the differences in the implementation of javascript with typescript or maybe other factors. Thank you for trying my advice and apologize for trouble

[jeankassio]

Tested today

[PurpShell]

lgtm

[SheIITear]

Lgtm

[PurpShell]

This is not for the pairing code, this is stupid and incorrect. the second argument is the one for the browser type not the first one. Just reverse

[Salientekill]

fix #481 #228

If we use

browser: ['MyAwesomeApp', 'chrome', '22.5.0']

WhatsApp shows the browser's icon in Linked Devices

I tried using your example and it didn't work

[Riders004]

fix #481 #228
If we use

browser: ['MyAwesomeApp', 'chrome', '22.5.0']

WhatsApp shows the browser's icon in Linked Devices

I tried using your example and it didn't work

Upgrade Baileys

[Riders004]

This is not for the pairing code, this is stupid and incorrect. the second argument is the one for the browser type not the first one. Just reverse

I tried it's working for both pairing code and qr code

[Riders004]

I'm qr is working but in pair its say incorrect code what I do

Excuse me, I can see your socket configuration in the browser section browser: ["device", "browser", "version"]

That's my Browser Configuration and I also added in my Baileys that i added in my pair code script folder
If you want browser version then you can find on google

I don't know for sure how it can be an error to you (because I actually don't really understand typescript) But I use configuration like this browser: ["Mac OS", "Safari", clVer] and make an experiment by changing the code in node_modules/baileys as I said earlier and it work for me for qrcode and pairing code So on the linked device you will see like this

That browser Config I use that for pairing code you can use in qr code

[Salientekill]

fix #481 #228
If we use

browser: ['MyAwesomeApp', 'chrome', '22.5.0']

WhatsApp shows the browser's icon in Linked Devices

I tried using your example and it didn't work

Upgrade Baileys

I already updated, but it still doesn't work:

browser: ['MyAwesomeApp', 'chrome', '22.5.0']

[SheIITear]

Do not fill this pr with unrelated comments. If you need help ask on the offtopic channel on the discord server.

[Salientekill]

Do not fill this pr with unrelated comments. If you need help ask on the offtopic channel on the discord server.

But it's related to this pr, I tried using the same way as the examples and it didn't work

[SheIITear]

Do not fill this pr with unrelated comments. If you need help ask on the offtopic channel on the discord server.

But it's related to this pr, I tried using the same way as the examples and it didn't work

Still this is not the place to ask for help. Locking this pr, you can continue the conversation on the server.