Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix message content type detection #504

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

cristiano-linvix
Copy link
Contributor

Resolved the function that detects the type of message received.

Previously, the function checked if the message ended with "Message" but we need to see if it includes "Message" because of some messages that contain a suffix after "Message"

ex:

pollCreationMessageV2
pollCreationMessageV3
viewOnceMessageV2
viewOnceMessageV2Extension

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@cristiano-linvix/Baileys#master
# YARN v2
yarn add @whiskeysockets/baileys@cristiano-linvix/Baileys#master

@cristiano-linvix
Copy link
Contributor Author

@barkerpedro @arccoza @galiazzi

Good evening guys, how are you?
I know it's very busy for you, can you take a look at this PR?

Thank you so much!!!

@cristiano-linvix
Copy link
Contributor Author

Hi guys how are you?

How does the process of merging these PRs work?

I know it's always busy there, it's been a few days since I opened the PR, how can we do the merge?

Thank you so much!

@cristiano-linvix
Copy link
Contributor Author

up

Copy link
Collaborator

@PurpShell PurpShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your first contribution, welcome to Baileys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants