Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max msg retry count #572

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

laxeder
Copy link
Contributor

@laxeder laxeder commented Jan 3, 2024

This will allow you to better configure the maximum amount of retry possible. In cases where the default count is not enough.

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@laxeder/Baileys#max-retry
# YARN v2
yarn add @whiskeysockets/baileys@laxeder/Baileys#max-retry

Copy link
Contributor

@azudindaem azudindaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 is more than enough.. for flexibility i don't have any problem with this PR

Copy link
Collaborator

@PurpShell PurpShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@laxeder
Copy link
Contributor Author

laxeder commented Jan 5, 2024

5 is more than enough.. for flexibility i don't have any problem with this PR

In rarer cases it reaches the limit, in addition to limiting better handling of the send retry request

@T3uZ
Copy link

T3uZ commented Jan 12, 2024

up plis

@PurpShell PurpShell merged commit 18990f8 into WhiskeySockets:master Jan 19, 2024
2 checks passed
PurpShell added a commit that referenced this pull request Mar 12, 2024
* feat: Set in group settings memberAddMode and joinApprovalMode (#534)

* feat: Set in group settings memberAddMode and joinApprovalMode

* fix lint

* fix lint

* fix conflict

---------

Co-authored-by: Bob <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: Rajeh Taher <[email protected]>

* feat: memberAddMode and joinApprovalMode in groups.update (#532)

* feat: memberAddMode and joinApprovalMode

* feat: memberAddMode and joinApprovalMode

* Update process-message.ts

* fix lint

* Update messages-recv.ts

* Update GroupMetadata.ts

* Update messages-recv.ts

* Update messages-recv.ts

* chore: fix linting and code efficiency

* fix lint

* Fix lint

* Update process-message.ts

* Update process-message.ts

---------

Co-authored-by: Bob <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: Rajeh Taher <[email protected]>

* Update package.json (#506)

Any version of cache-manager greater than 4.0.1 stopped coming with an index.js resulting to 

`@whiskeysockets/baileys/node_modules/cache-manager/dist/index.js'. Please verify that the package.json has a valid "main" entry` error

* Use senderTimestampMs instead of messageTimestamp (#348)

* Use senderTimestampMs instead of messageTimestamp

* Add .toNumber(), because senderTimestampMs is Long

* chore: Fix linting

---------

Co-authored-by: Rajeh Taher <[email protected]>

* feat: add option for Windows browser (#303)

* chore(package.json): update protobufjs dependency from version 6.11.3 to 7.2.4 for compatibility and potential bug fixes (#302)

Co-authored-by: Rajeh Taher <[email protected]>

* feat: auto version hash (#290)

* feat: auto version hash

* sort imports

---------

Co-authored-by: Rajeh Taher <[email protected]>

* chore: updated proto/version to v2.2403.2 (#288)

Co-authored-by: edgardmessias <[email protected]>

* bump: sharp to ^0.32.2 (#245)

* feat: Add max msg retry count (#572)

* Update getDevice (#569)

Co-authored-by: Bob <[email protected]>

* chore: Add more docs regarding status@broadcast messages

* Support for receiving "view once" audio messages (#595)

* Update size calculation in extractGroupMetadata function (#581)

* feat: If need approval to join the group in groupMetadata (#533)

* If need approval to join the group

* If need approval to join the group

* Update groups.ts

* Update groups.ts

* fix lint

* Update groups.ts

* Update groups.ts

---------

Co-authored-by: Bob <[email protected]>
Co-authored-by: Bob <[email protected]>

* chore: fix typing (duplicate property due to overlapping PRs)

* chore: fix github action release

* chore: fix manual release action

* chore: revert changes to package.json

* fix: quick test to diagnose working dir issue

* fix yml syntax

* chore: fix yarn.lock

* chore: fix release workflow

* chore(release): v6.6.0

* Update FUNDING.yml

* chore: fix audio decode error due to passing spread argument

* Change the default browser to fix pairing code

---------

Co-authored-by: Bob <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: NOOB-KILLERBOT <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Ashary Vermaysha <[email protected]>
Co-authored-by: ugurgungezerler <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: edgardmessias <[email protected]>
Co-authored-by: Muhammed Kaplan <[email protected]>
Co-authored-by: Alex Sandro <[email protected]>
Co-authored-by: Javier Cuevas <[email protected]>
Co-authored-by: Wender Teixeira <[email protected]>
Co-authored-by: ShellTear <[email protected]>
Co-authored-by: Timothy Dillan <[email protected]>
Co-authored-by: Pokoke <[email protected]>
Co-authored-by: Alessandro Autiero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants