Newsletter support (absorbs #820 and #822) #961
+488
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * add reactions support * changes * fix type error * add enableLiveUpdates fn / remove reaction handler in decode * add newsletter functions (to test) * add events / other things * fix handler * add extract metadata * add types * add admin events / some fixes * better typing * typing / add some functions (to test) * add parse for fetchMessages * improve parseFetched / typing * finish * lint / fix metadata * better newsletter socket structure * fix / add tos query in newsletterCreate --------- Co-authored-by: Rajeh Taher <[email protected]>
|
Thanks for your contribution. The next step is to wait for review and approval to merge it to main repository The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it. To test this PR you can run the following command below: |
|
As I can see it doesn't support sending media yet right? |
|
I tried this version but sending image does not seems to work in desktop.
However, in my smartphone everything works.
|
|
Raw media uploads to be added soon |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.