Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to warn against using scopes with assisted injection #171

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Jan 2, 2024

Description

Related Issue

Checklist

  • My code follows the style guidelines of this project (./gradlew lint spotlessCheck)
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.70%. Comparing base (287449f) to head (79b0160).

Files Patch % Lines
.../whosnickdoglio/dagger/DaggerRulesIssueRegistry.kt 0.00% 1 Missing ⚠️
...dagger/detectors/ScopedAssistedInjectedDetector.kt 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   89.34%   89.70%   +0.35%     
==========================================
  Files          20       21       +1     
  Lines         676      719      +43     
  Branches       72       74       +2     
==========================================
+ Hits          604      645      +41     
- Misses         49       50       +1     
- Partials       23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch 2 times, most recently from 04de865 to 271aa21 Compare January 5, 2024 17:48
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch from 271aa21 to 46e1b47 Compare January 13, 2024 18:17
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch 3 times, most recently from 3b60a9c to 1624e34 Compare April 6, 2024 15:27
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch 2 times, most recently from 82dba24 to 7f734fa Compare April 20, 2024 13:13
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch from 7f734fa to cace876 Compare April 27, 2024 19:58
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch 2 times, most recently from c511b5e to 2c1c72e Compare June 1, 2024 03:28
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch 2 times, most recently from 59dc186 to 9fc3830 Compare June 14, 2024 01:52
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch 2 times, most recently from 3109713 to 139b8cb Compare July 13, 2024 14:22
@WhosNickDoglio WhosNickDoglio force-pushed the feature/ndoglio/assisted-no-scoping branch from 139b8cb to 79b0160 Compare July 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant