Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a rule to suggest constructor injection over Provides method #20

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhosNickDoglio
Copy link
Owner

@WhosNickDoglio WhosNickDoglio commented Apr 8, 2023

Description

Related Issue

Motivation and Context

Implementation Summary

Checklist

  • My code follows the style guidelines of this project (gradlew detektAll)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I hae mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.71%. Comparing base (287449f) to head (64d2d42).

Files Patch % Lines
...ectors/ConstructorInjectionOverProvidesDetector.kt 73.91% 5 Missing and 1 partial ⚠️
.../whosnickdoglio/dagger/DaggerRulesIssueRegistry.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   89.34%   88.71%   -0.64%     
==========================================
  Files          20       21       +1     
  Lines         676      700      +24     
  Branches       72       75       +3     
==========================================
+ Hits          604      621      +17     
- Misses         49       55       +6     
- Partials       23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 3 times, most recently from f64be0a to 23d5dd1 Compare April 6, 2024 15:26
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from 9249bd4 to 3336cae Compare April 20, 2024 13:13
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from 41c125f to caec8ce Compare June 1, 2024 03:28
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from e7e821e to 4c5831f Compare June 14, 2024 01:52
@WhosNickDoglio WhosNickDoglio force-pushed the constructor-over-provides branch 2 times, most recently from 25dac55 to 876986e Compare July 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant