Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PacketEvents packet handler not restricting outbound server packets #344

Closed
WiIIiam278 opened this issue Jul 10, 2024 · 0 comments
Closed

PacketEvents packet handler not restricting outbound server packets #344

WiIIiam278 opened this issue Jul 10, 2024 · 0 comments
Labels
type: bug This issue is about something that isn't working as intended

Comments

@WiIIiam278
Copy link
Owner

https://github.com/WiIIiam278/HuskSync/blob/master/bukkit/src/main/java/net/william278/husksync/listener/BukkitPacketEventsLockedPacketListener.java

While the ProtocolLib one does handle this:

https://github.com/WiIIiam278/HuskSync/blob/master/bukkit/src/main/java/net/william278/husksync/listener/BukkitProtocolLibLockedPacketListener.java
@WiIIiam278 WiIIiam278 added the type: bug This issue is about something that isn't working as intended label Jul 10, 2024
pull bot added a commit to erxson/HuskSync-build that referenced this issue Aug 10, 2024
@pull @WiIIiam278
[pull] master from WiIIiam278:master (#1)
7f13832 
* refactor: disable potion effects & attributes by default

* feat: deprecate Toast notifications

* fix: Cancel outbound PacketEvents packets, close WiIIiam278#344

* fix: add boot warning to fabric

* fix: stop syncing ambient effects, close WiIIiam278#289

Effects from beacons, conduits, and The Warden will no longer sync.

* refactor: auto-reformat code

* build: bump runtime dependencies

* feat: improve server version status text

* refactor: revert "disable attributes/potion effects by default"

* docs: update config file

---------

Co-authored-by: William <[email protected]>
pull bot added a commit to erxson/HuskSync-build that referenced this issue Aug 11, 2024
@pull @WiIIiam278
[pull] master from WiIIiam278:master (#2)
344a25f 
* refactor: disable potion effects & attributes by default

* feat: deprecate Toast notifications

* fix: Cancel outbound PacketEvents packets, close WiIIiam278#344

* fix: add boot warning to fabric

* fix: stop syncing ambient effects, close WiIIiam278#289

Effects from beacons, conduits, and The Warden will no longer sync.

* refactor: auto-reformat code

* build: bump runtime dependencies

* feat: improve server version status text

* refactor: revert "disable attributes/potion effects by default"

* docs: update config file

---------

Co-authored-by: William <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug This issue is about something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WiIIiam278