Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fabric 1.21 #339

Merged
merged 8 commits into from
Aug 25, 2024
Merged

Support Fabric 1.21 #339

merged 8 commits into from
Aug 25, 2024

Conversation

hui1601
Copy link
Contributor

@hui1601 hui1601 commented Jul 7, 2024

I've patched the code to reflect the breaking changes in the Fabric API and to match Minecraft 1.21.

NOTE: Please test carefully as I don't have time to test that all the features work.

@WiIIiam278
Copy link
Owner

WiIIiam278 commented Jul 7, 2024

Thanks, but I currently just want to support 1.20.1 as that's the one with cobblemon and all the mods on :)

However, will keep this in mind on the side for the moment as this will become relevant in the near future.

@WiIIiam278 WiIIiam278 added the platform: fabric This issue is specific to Fabric label Jul 21, 2024
@EliasB-NU
Copy link

I compiled it myself and are running it on my server, works perfectly fine.

@Rozbiynk
Copy link

cant build latest commits
изображение

@hui1601
Copy link
Contributor Author

hui1601 commented Jul 24, 2024

@Rozbiynk That's a error related with the network status.
But, the master branch changes cause build other errors.

try below changes with latest commit.(I havn't tested this)

diff --git a/build.gradle b/build.gradle
index 86ac9d9..d993b38 100644
--- a/build.gradle
+++ b/build.gradle
@@ -131,7 +131,7 @@ subprojects {
     }
 
     // API publishing
-    if (['common', 'bukkit', 'fabric'].contains(project.name)) {
+    if (['common', 'fabric'].contains(project.name)) {
         java {
             withSourcesJar()
             withJavadocJar()
@@ -158,19 +158,6 @@ subprojects {
                 }
             }
 
-            if (['bukkit'].contains(project.name)) {
-                publications {
-                    mavenJavaBukkit(MavenPublication) {
-                        groupId = 'net.william278.husksync'
-                        artifactId = 'husksync-bukkit'
-                        version = "$rootProject.version"
-                        artifact shadowJar
-                        artifact sourcesJar
-                        artifact javadocJar
-                    }
-                }
-            }
-
             if (['fabric'].contains(project.name)) {
                 publications {
                     mavenJavaFabric(MavenPublication) {
diff --git a/settings.gradle b/settings.gradle
index fefb698..7d487df 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -8,7 +8,5 @@ pluginManagement {
 rootProject.name = 'HuskSync'
 include(
         'common',
-        'bukkit',
-        'paper',
         'fabric'
-)
\ No newline at end of file
+)

@Rozbiynk
Copy link

look like it compiled
изображение

@La1m1e
Copy link

La1m1e commented Jul 24, 2024

Locked map sync doesnt work for me. Also sends this message every time i switch servers or log off
image

@La1m1e
Copy link

La1m1e commented Jul 24, 2024

Locked map sync doesnt work for me. Also sends this message every time i switch servers or log off image

Also it resets my coordinates in each server to ones on which i joined the first time, while inventory and other things sync

Copy link
Owner

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your work here!
We're now targeting Fabric 1.20.1 in a separate branch so we'll get this merged into master. I think there's a couple things todo after merging, but that can be tidied up before a release :)

@WiIIiam278 WiIIiam278 merged commit 621afcd into WiIIiam278:master Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: fabric This issue is specific to Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants