feat: default handler now accepts _every_ message type #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides better feedback on failures than just asserting if it was called or not
allow downstream integrations to use the default handler to filter out all the different message types they might want to use. this way we needn't create `setLocationHandler`, `setCallHandler`, etc. this also modifies the exports of this library to add the `MESSAGE_TYPE` map to the WickrBot class. it's not the most elegant way of handling this, but with the way we're currently doing the exports it is the only way to export > 1 thing afaik. changing the import behavior is something for a v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow downstream integrations to use the default handler to filter out
all the different message types they might want to use. this way we
needn't create
setLocationHandler,setCallHandler, etc.this also modifies the exports of this library to add the
MESSAGE_TYPEmap to the WickrBot class. it's not the most elegant way of handling
this, but with the way we're currently doing the exports it is the only
way to export > 1 thing afaik. changing the import behavior is something
for a v2.